Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query_keyboard_enhancement_flags to read enabled flags #958

Conversation

the-mikedavis
Copy link
Contributor

This is mostly a refactor of supports_keyboard_enhancement and its helper functions. We previously discarded the response to the CSI ? u query but this returns the currently active flags. This response value can be useful for a client to know which flags to emit to disable the keyboard enhancement protocol or to know which flags a terminal supports (after the client has pushed flags).

Fixes #952

This is mostly a refactor of `supports_keyboard_enhancement` and its
helper functions. We previously discarded the response to the `CSI ? u`
query but this returns the currently active flags. This response value
can be useful for a client to know which flags to emit to disable the
keyboard enhancement protocol or to know which flags a terminal supports
(after the client has pushed flags).
@the-mikedavis the-mikedavis force-pushed the md/query-keyboard-enhancement-flags branch from 1f9a5c3 to 9c9fd30 Compare December 16, 2024 18:11
@TimonPost TimonPost merged commit 1e7622c into crossterm-rs:master Feb 2, 2025
6 checks passed
@TimonPost
Copy link
Member

Ty 👍

@the-mikedavis the-mikedavis deleted the md/query-keyboard-enhancement-flags branch February 2, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More granular query for keyboard enhancement protocol support
2 participants